Bug 246224 - A/B test results should only highlight when p-value <= 0.05
Summary: A/B test results should only highlight when p-value <= 0.05
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-07 11:17 PDT by dewei_zhu
Modified: 2022-10-10 10:20 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2022-10-07 11:17:09 PDT 
Current UI will highlight when p-value <= 0.2, but engineer uses 0.05 in practice. UI should match this behavior.
Comment 1 dewei_zhu 2022-10-07 11:17:18 PDT 
<rdar://problem/100648227>
Comment 2 dewei_zhu 2022-10-07 11:19:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5145
Comment 3 EWS 2022-10-10 10:20:51 PDT 
Committed 255351@main (c616083bd1a5): <https://commits.webkit.org/255351@main>

Reviewed commits have been landed. Closing PR #5145 and removing active labels.