Bug 246044 - [Outline] Introduce BorderData::Radii
Summary: [Outline] Introduce BorderData::Radii
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 20807
  Show dependency tree / graph
 
Reported: 2022-10-04 15:26 PDT by zalan
Modified: 2022-10-12 15:29 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.50 KB, patch)
2022-10-04 15:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-10-04 15:26:16 PDT 
ssia
Comment 1 zalan 2022-10-04 15:31:39 PDT 
Created attachment 462797 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-10-04 17:07:03 PDT 
Comment on attachment 462797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462797&action=review

> COMMIT_MESSAGE:7
> +(This structure is going to be used to pass around radii information in BorderPainter)

Can you use RoundedRect::Radii instead? Do you need LengthSize, or just LayoutSize for radii?
Comment 3 zalan 2022-10-04 17:08:39 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 462797 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462797&action=review
> 
> > COMMIT_MESSAGE:7
> > +(This structure is going to be used to pass around radii information in BorderPainter)
> 
> Can you use RoundedRect::Radii instead? Do you need LengthSize, or just
> LayoutSize for radii?
RoundedRect::Radii is resolved, this is computed radii.
Comment 4 EWS 2022-10-05 08:28:25 PDT 
Committed 255172@main (387077670b14): <https://commits.webkit.org/255172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462797 [details].
Comment 5 Radar WebKit Bug Importer 2022-10-05 08:29:18 PDT 
<rdar://problem/100808696>