Bug 246042 - Remove `:-webkit-full-screen-ancestor` pseudo-class
Summary: Remove `:-webkit-full-screen-ancestor` pseudo-class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 229333
  Show dependency tree / graph
 
Reported: 2022-10-04 15:06 PDT by Tim Nguyen (:ntim)
Modified: 2024-01-28 02:49 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-10-04 15:06:37 PDT 
They were only used for internal purposes, we can remove them. `:has(:fullscreen)` and variations covers these use-cases if it ever turns out to be useful for the web.
Comment 1 Radar WebKit Bug Importer 2022-10-04 15:06:50 PDT 
<rdar://problem/100782937>
Comment 2 Anne van Kesteren 2023-12-29 01:01:05 PST 
What about :-webkit-full-screen-controls-hidden?

It appears :-webkit-full-screen-document still has internal usage.
Comment 3 Tim Nguyen (:ntim) 2024-01-01 22:34:50 PST 
> It appears :-webkit-full-screen-document still has internal usage.

It should be turned into an internal pseudo-class.

> What about :-webkit-full-screen-controls-hidden?

If it's unused, then yeah, it should be removed. I'm more worried about the web compat impact of removing any of those, but maybe the impact is low?
Comment 4 Tim Nguyen (:ntim) 2024-01-27 15:32:23 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23367
Comment 5 EWS 2024-01-28 02:49:00 PST 
Committed 273620@main (ac6af5889f32): <https://commits.webkit.org/273620@main>

Reviewed commits have been landed. Closing PR #23367 and removing active labels.