Bug 246036 - [css-grid] Layout excluded children before updateLogicalWidth
Summary: [css-grid] Layout excluded children before updateLogicalWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-04 13:47 PDT by Rob Buis
Modified: 2022-10-05 03:03 PDT (History)
13 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2022-10-04 13:48 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2022-10-04 22:46 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-10-04 13:47:05 PDT
Layout excluded children before updateLogicalWidth.
Comment 1 Rob Buis 2022-10-04 13:48:02 PDT
Created attachment 462796 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-10-04 13:48:58 PDT
Comment on attachment 462796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462796&action=review

> COMMIT_MESSAGE:1
> +Layout excluded children before updateLogicalWidth 

This title should mention Grid.

> COMMIT_MESSAGE:6
> +Layout excluded children before calling updateLogicalWidth since

Is there a behavior change that can be tested?
Comment 3 Rob Buis 2022-10-04 22:46:22 PDT
Created attachment 462806 [details]
Patch
Comment 4 EWS 2022-10-05 03:02:40 PDT
Committed 255163@main (3a49dda1f8f6): <https://commits.webkit.org/255163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462806 [details].
Comment 5 Radar WebKit Bug Importer 2022-10-05 03:03:17 PDT
<rdar://problem/100801246>