Bug 246035 - [webkitscmpy] Handle unexpected PR data
Summary: [webkitscmpy] Handle unexpected PR data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-04 13:36 PDT by Jonathan Bedard
Modified: 2022-10-18 13:14 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-10-04 13:36:28 PDT
GitHub some times populates PR json data with unexpected 'None's in certain places. I'm not sure what the root cause is, I suspect it's related to creating a PR with a very large description. We should at least handle 'None' in more places in json data coming from GitHub.
Comment 1 Radar WebKit Bug Importer 2022-10-04 13:41:56 PDT
<rdar://problem/100778857>
Comment 2 Jonathan Bedard 2022-10-04 13:43:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4996
Comment 3 EWS 2022-10-14 13:42:15 PDT
Committed 255549@main (9dd26e36dd84): <https://commits.webkit.org/255549@main>

Reviewed commits have been landed. Closing PR #4996 and removing active labels.
Comment 4 EWS 2022-10-18 13:14:57 PDT
Committed 252432.592@safari-7614-branch (d068f8be2383): <https://commits.webkit.org/252432.592@safari-7614-branch>

Reviewed commits have been landed. Closing PR #143 and removing active labels.