Bug 246014 - [LFC] Rename ContainerBox to ElementBox
Summary: [LFC] Rename ContainerBox to ElementBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-04 06:02 PDT by Antti Koivisto
Modified: 2022-10-04 09:39 PDT (History)
14 users (show)

See Also:

Attachments
Patch (232.48 KB, patch)
2022-10-04 06:10 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (233.10 KB, patch)
2022-10-04 08:17 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-10-04 06:02:25 PDT 
It represents non-text boxes generated by elements (and also anonymous boxes). Being a container is incidental.
Comment 1 Radar WebKit Bug Importer 2022-10-04 06:03:24 PDT 
<rdar://problem/100759523>
Comment 2 Antti Koivisto 2022-10-04 06:10:46 PDT 
Created attachment 462786 [details]
Patch
Comment 3 zalan 2022-10-04 07:47:10 PDT 
Comment on attachment 462786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462786&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:70
> +        ElementBoxFlag           = 1 << 1,

spacing
Comment 4 Antti Koivisto 2022-10-04 08:17:31 PDT 
Created attachment 462789 [details]
Patch
Comment 5 EWS 2022-10-04 09:39:48 PDT 
Committed 255130@main (2b4114c9c3bd): <https://commits.webkit.org/255130@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462789 [details].