Bug 245982 - [WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling
Summary: [WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-03 14:49 PDT by Fujii Hironori
Modified: 2022-10-05 02:58 PDT (History)
9 users (show)

See Also:

Attachments
WIP patch (2.34 KB, patch)
2022-10-03 21:51 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2022-10-04 22:24 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-10-03 14:49:37 PDT 
[WinCairo] PageUp, PageDown, Home and End keys don't start keyboard scroll

255031@main (bug#228159) enabled EventHandlerDrivenSmoothKeyboardScrollingEnabled.
It works nicely for Arrow keys, Space key and Shift+Space key,
but for PageUp, PageDown, Home and End keys.
Comment 1 Fujii Hironori 2022-10-03 21:02:49 PDT 
241197@main (bug#229733) fixed PageUp and PageDown for the smooth keyboard scrolling.
But, 252663@main (bug#242523) removed the code.
Mac port is using EditCommand (ScrollPageBackward and ScrollPageForward) for PageUp and PageDown now.
Comment 2 Fujii Hironori 2022-10-03 21:51:26 PDT 
Created attachment 462779 [details]
WIP patch
Comment 3 Fujii Hironori 2022-10-04 22:07:20 PDT 
fast/dom/horizontal-scrollbar-in-rtl.html is failing for mac-wk2.
I will split apart EditorCommand.cpp part into another patch.
Comment 4 Fujii Hironori 2022-10-04 22:24:37 PDT 
Created attachment 462805 [details]
Patch
Comment 5 Ross Kirsling 2022-10-05 00:22:58 PDT 
Comment on attachment 462805 [details]
Patch

r=me
Comment 6 EWS 2022-10-05 02:57:00 PDT 
Committed 255162@main (c00cdc0f009b): <https://commits.webkit.org/255162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462805 [details].
Comment 7 Radar WebKit Bug Importer 2022-10-05 02:58:18 PDT 
<rdar://problem/100801142>