Bug 245908 - [LBSE] Assure <foreignObject> HTML descendants create a new formatting context
Summary: [LBSE] Assure <foreignObject> HTML descendants create a new formatting context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
: 53082 246709 (view as bug list)
Depends on: 246709
Blocks: 90738
  Show dependency tree / graph
 
Reported: 2022-09-30 16:05 PDT by Nikolas Zimmermann
Modified: 2022-12-02 16:06 PST (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-09-30 16:05:24 PDT 
This breaks e.g. margin handling for block-children of <foreignObject> (broken since forever in Safari). The fix is trivial in LBSE: establish a new formatting context at the RenderSVGForeignObject boundary.
Comment 1 Nikolas Zimmermann 2022-10-05 03:40:56 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5021
Comment 2 Radar WebKit Bug Importer 2022-10-07 16:06:18 PDT 
<rdar://problem/100916389>
Comment 3 EWS 2022-10-17 07:34:58 PDT 
Committed 255626@main (912165516f6a): <https://commits.webkit.org/255626@main>

Reviewed commits have been landed. Closing PR #5021 and removing active labels.
Comment 4 Ahmad Saleem 2022-10-17 07:58:26 PDT 
*** Bug 23963 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2022-10-18 14:06:57 PDT 
Re-opened since this is blocked by bug 246709
Comment 6 Hercules Hjalmarsson 2022-10-20 11:01:53 PDT 
This was reverted in 255793@main due to introducing a crashing layout test. 

Bug information in bug 246709.
Comment 7 Hercules Hjalmarsson 2022-10-20 11:13:28 PDT 
*** Bug 246709 has been marked as a duplicate of this bug. ***
Comment 8 Nikolas Zimmermann 2022-11-22 06:55:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6735
Comment 9 EWS 2022-11-22 17:45:18 PST 
Committed 256960@main (7fd975ae7427): <https://commits.webkit.org/256960@main>

Reviewed commits have been landed. Closing PR #6735 and removing active labels.
Comment 10 Ahmad Saleem 2022-12-02 16:06:25 PST 
*** Bug 53082 has been marked as a duplicate of this bug. ***