Bug 245853 - [webkitscmpy] GitHub Release Asset should be uploaded as the entire body of the request instead of a part of multipart/form-data
Summary: [webkitscmpy] GitHub Release Asset should be uploaded as the entire body of t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roy Reapor
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-29 16:05 PDT by Roy Reapor
Modified: 2022-10-07 08:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Reapor 2022-09-29 16:05:15 PDT 
GitHub Release Asset should be uploaded as the entire body of the request instead of a part of multipart/form-data.

Currently `upload_release_asset()` will cause the uploaded file to contain form-data, corrupting the file.
Comment 1 Radar WebKit Bug Importer 2022-09-29 16:06:01 PDT 
<rdar://problem/100586484>
Comment 2 Roy Reapor 2022-09-29 16:49:46 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4842
Comment 3 EWS 2022-09-29 19:18:22 PDT 
Committed 255018@main (2f7d59b245e9): <https://commits.webkit.org/255018@main>

Reviewed commits have been landed. Closing PR #4842 and removing active labels.
Comment 4 EWS 2022-10-07 08:02:43 PDT 
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
Comment 5 EWS 2022-10-07 08:26:12 PDT 
Committed 252432.511@safari-7614-branch (fd94bbec5de8): <https://commits.webkit.org/252432.511@safari-7614-branch>

Reviewed commits have been landed. Closing PR #102 and removing active labels.