Bug 245846 - Fix warnings in curl backend
Summary: Fix warnings in curl backend
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-29 13:32 PDT by Don Olmstead
Modified: 2022-10-06 13:33 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-09-29 13:32:12 PDT 
Clang 15 is reporting warnings in the code

C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:158:17: error: enumeration values 'OpCodeContinuation', 'OpCodePong', and 'OpCodeInvalid' not handled in switch [-Werror,-Wswitch]
        switch (opCode) {
                ^~~~~~
C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:375:138: error: lambda capture 'isCrossOrigin' is not used [-Werror,-Wunused-lambda-capture]
    m_client->willPerformHTTPRedirection(WTFMove(response), WTFMove(request), [this, protectedThis = Ref { *this }, didChangeCredential, isCrossOrigin](const ResourceRequest& newRequest) {
                                                                                                                                       ~~^~~~~~~~~~~~~

Also check MSVC so we can turn warnings as errors on for WinCairo and PlayStation.
Comment 1 Radar WebKit Bug Importer 2022-10-06 13:33:18 PDT 
<rdar://problem/100867914>