Bug 245812 - 'run-benchmark' should only use 'local_git_archive' when commit exists
Summary: 'run-benchmark' should only use 'local_git_archive' when commit exists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-28 19:27 PDT by dewei_zhu
Modified: 2022-09-29 13:46 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2022-09-28 19:27:01 PDT 
Previously, it will be eligible as long as current directory is a git checkout, which does not ensure the commit/reference exists.
Comment 1 dewei_zhu 2022-09-28 19:27:22 PDT 
<rdar://problem/100539553>
Comment 2 dewei_zhu 2022-09-28 19:29:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4819
Comment 3 EWS 2022-09-29 13:46:01 PDT 
Committed 255012@main (c45d27767827): <https://commits.webkit.org/255012@main>

Reviewed commits have been landed. Closing PR #4819 and removing active labels.