Bug 245792 - Add RenderBox::lastLineBaseline
Summary: Add RenderBox::lastLineBaseline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-28 11:01 PDT by Sammy Gill
Modified: 2022-10-22 04:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-09-28 11:01:26 PDT 
We already have RenderBox::firstLineBaseline, so in order to begin implementing last baseline alignment in various scenarios, we should have a virtual method here that can be overridden when necessary
Comment 1 Radar WebKit Bug Importer 2022-09-28 11:01:59 PDT 
<rdar://problem/100516446>
Comment 2 Sammy Gill 2022-09-28 11:46:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4799
Comment 3 EWS 2022-10-05 10:41:38 PDT 
Committed 255179@main (dc7fdb2e0a35): <https://commits.webkit.org/255179@main>

Reviewed commits have been landed. Closing PR #4799 and removing active labels.
Comment 4 EWS 2022-10-22 04:26:36 PDT 
Committed 252432.638@safari-7614-branch (264d60308653): <https://commits.webkit.org/252432.638@safari-7614-branch>

Reviewed commits have been landed. Closing PR #155 and removing active labels.