RESOLVED FIXED 245723
[GTK] Non-unified GTK4 build broken 
https://bugs.webkit.org/show_bug.cgi?id=245723
Summary [GTK] Non-unified GTK4 build broken
Alberto Garcia
Reported 2022-09-27 03:49:29 PDT
/tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp: In constructor ‘WebKit::NativeWebMouseEvent::NativeWebMouseEvent(GdkEvent*, int, std::optional<WebCore::FloatSize>)’: /tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp:36:21: error: ‘gdk_event_copy’ was not declared in this scope; did you mean ‘gst_event_copy’? 36 | , m_nativeEvent(gdk_event_copy(event)) | ^~~~~~~~~~~~~~
Attachments
Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2022-09-27 04:00:28 PDT
This needs to include GtkVersioning.h --- a/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp +++ b/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp @@ -27,6 +27,7 @@ #include "NativeWebMouseEvent.h" #include "WebEventFactory.h" +#include <Source/WebCore/platform/gtk/GtkVersioning.h> #include <gdk/gdk.h> namespace WebKit {
Claudio Saavedra
Comment 2 2022-09-27 04:24:47 PDT
Shouldn't it be #include <WebCore/GtkVersioning.h> ?
Alberto Garcia
Comment 3 2022-09-27 04:57:01 PDT
(In reply to Claudio Saavedra from comment #2) > Shouldn't it be #include <WebCore/GtkVersioning.h> ? yes, sorry, I tested a complete build and it works now #include "WebEventFactory.h" +#include <WebCore/GtkVersioning.h> #include <gdk/gdk.h>
Adrian Perez
Comment 4 2022-09-28 04:40:32 PDT
The issue is present in “main” as well, so I have removed the [2.28.0] tag from the summary. I can make sure this gets backported to the release branch 😉️
Adrian Perez
Comment 5 2022-09-28 04:43:24 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4789
EWS
Comment 6 2022-09-28 04:46:43 PDT
Committed 254950@main (8b91cf150e8a): <https://commits.webkit.org/254950@main> Reviewed commits have been landed. Closing PR #4789 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.