Bug 245694 - AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true
Summary: AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when A...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-26 13:44 PDT by Tyler Wilcock
Modified: 2022-09-26 23:51 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.58 KB, patch)
2022-09-26 14:11 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-09-26 13:44:13 PDT 
AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true
Comment 1 Radar WebKit Bug Importer 2022-09-26 13:44:26 PDT 
<rdar://problem/100426498>
Comment 2 Tyler Wilcock 2022-09-26 13:44:44 PDT 
rdar://100245048
Comment 3 Tyler Wilcock 2022-09-26 14:11:24 PDT 
Created attachment 462631 [details]
Patch
Comment 4 chris fleizach 2022-09-26 14:14:27 PDT 
Comment on attachment 462631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462631&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598
> +            if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree())

this is nice to string these in a single if. is this a new ability
Comment 5 Tyler Wilcock 2022-09-26 18:37:40 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 462631 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462631&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598
> > +            if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree())
> 
> this is nice to string these in a single if. is this a new ability
Indeed! It came with C++17.
Comment 6 EWS 2022-09-26 23:51:15 PDT 
Committed 254899@main (523acc306f2b): <https://commits.webkit.org/254899@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462631 [details].