Bug 245658 - Provide dedicated functions for computation of from and to values for composite animations
Summary: Provide dedicated functions for computation of from and to values for composi...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-26 00:42 PDT by Antoine Quint
Modified: 2022-10-03 00:43 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-09-26 00:42:13 PDT 
Sam Weinig made a good point in https://github.com/WebKit/WebKit/pull/4674#issuecomment-1257318558:

> As a side note, so not needed for this PR, unless there is some great reason I don't quite understand to
> keep it the way it is, I think we should consider modeling these different compositing operations in a way
> that is easier to understand.
> I think the obvious way to do this would be to stop using the blend() functions for computing the used
> from/to for additive/accumulative animations, and instead add a new entry point. Obviously this would
> add a bit of extra boilerplate, but I think the clarity would be good in the end.

I also agree with this, especially since we call blend() with progress = 1 at all times.
Comment 1 Radar WebKit Bug Importer 2022-10-03 00:43:16 PDT 
<rdar://problem/100706662>