Bug 245654 - [WGSL] Gardening of WGSL parser unit tests.
Summary: [WGSL] Gardening of WGSL parser unit tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-25 22:42 PDT by Dan Glastonbury
Modified: 2022-09-27 16:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-09-25 22:42:02 PDT 
Gardening of unit tests, including:
- Add full parsing tests for complete sample vertex and fragment shaders.
- Use XCTAssertTrue & XCTAssertEqual instead of XCTAssert.
- Refactor tests to use auto& instead of doubling up on type names.
- Add macros for common AST checks.
Comment 1 Radar WebKit Bug Importer 2022-09-25 22:42:41 PDT 
<rdar://problem/100397595>
Comment 2 Dan Glastonbury 2022-09-25 22:59:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4695
Comment 3 EWS 2022-09-27 16:08:20 PDT 
Committed 254932@main (0a4bde8f1d82): <https://commits.webkit.org/254932@main>

Reviewed commits have been landed. Closing PR #4695 and removing active labels.