RESOLVED FIXED245583
WebKit build failure since rebase of libwebrtc 
https://bugs.webkit.org/show_bug.cgi?id=245583
Summary WebKit build failure since rebase of libwebrtc
Timothy Hatcher
Reported 2022-09-23 09:52:26 PDT
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:293:45: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:313:43: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:320:43: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:396:51: Possible misuse of comma operator here .../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:604:50: Possible misuse of comma operator here
Attachments
Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-09-23 09:55:19 PDT
I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places.
Timothy Hatcher
Comment 2 2022-09-23 09:56:12 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4632
Timothy Hatcher
Comment 3 2022-09-23 09:57:14 PDT
(In reply to youenn fablet from comment #1) > I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places. Oh! I will do that instead of the fix I just pushed.
Timothy Hatcher
Comment 4 2022-09-23 10:31:08 PDT
I am not seeing the failures now after updating main.
Timothy Hatcher
Comment 5 2022-09-24 09:04:32 PDT
I am seeing this again due to adding new files and UnifiedSources changing.
Timothy Hatcher
Comment 6 2022-09-24 09:08:22 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4666
EWS
Comment 7 2022-09-24 09:53:55 PDT
Committed 254824@main (829b721f8a6c): <https://commits.webkit.org/254824@main> Reviewed commits have been landed. Closing PR #4666 and removing active labels.
Radar WebKit Bug Importer
Comment 8 2022-09-24 09:54:15 PDT
<rdar://problem/100363003>
Note You need to log in before you can comment on or make changes to this bug.