Bug 245513 - TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable
Summary: TextureMapperGL: edge distance anti-aliasing should use 2D distance to calcul...
Status: RESOLVED DUPLICATE of bug 245265
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 21:01 PDT by Fujii Hironori
Modified: 2022-09-26 22:46 PDT (History)
4 users (show)

See Also:

Attachments
antialiasing-z-positions.html (849 bytes, text/html)
2022-09-21 21:01 PDT, Fujii Hironori 		no flags Details
WIP patch (2.15 KB, patch)
2022-09-21 21:01 PDT, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-09-21 21:01:16 PDT 
Created attachment 462527 [details]
antialiasing-z-positions.html

TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable

> float viewportSpaceDistance = distance(centerInViewportCoordinates, controlPointInViewportCoordinates);

This code calculates the distance in homogeneous coordinates. z and w are included.
Comment 1 Fujii Hironori 2022-09-21 21:01:53 PDT 
Created attachment 462528 [details]
WIP patch
Comment 2 Fujii Hironori 2022-09-21 21:04:41 PDT 
Comment on attachment 462528 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462528&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:113
> +            float viewportSpaceDistance = distance(centerInViewportCoordinates.xy / centerInViewportCoordinates.w, controlPointInViewportCoordinates.xy / controlPointInViewportCoordinates.w);

We should avoid divisions. bug#245265 is going to solve this bug by calculating the denominator separately.
Comment 3 Fujii Hironori 2022-09-26 22:46:55 PDT 

*** This bug has been marked as a duplicate of bug 245265 ***