Bug 245421 - Fix !elementStyle.caretColor().isValid() check in FrameSelection.cpp
Summary: Fix !elementStyle.caretColor().isValid() check in FrameSelection.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-20 04:12 PDT by Tim Nguyen (:ntim)
Modified: 2022-09-20 04:23 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-09-20 04:12:36 PDT 
It should really be checking for `elementStyle.hasAutoCaretColor()`.
Comment 1 Radar WebKit Bug Importer 2022-09-20 04:14:29 PDT 
<rdar://problem/100166424>
Comment 2 Tim Nguyen (:ntim) 2022-09-20 04:16:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4525
Comment 3 EWS 2022-09-20 04:23:38 PDT 
Committed 254668@main (ec1b260043e4): <https://commits.webkit.org/254668@main>

Reviewed commits have been landed. Closing PR #4525 and removing active labels.