Bug 245417 - [LBSE] Activate sub-pixel precision for render tree dumps
Summary: [LBSE] Activate sub-pixel precision for render tree dumps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks: 90738
  Show dependency treegraph
 
Reported: 2022-09-20 01:38 PDT by Nikolas Zimmermann
Modified: 2022-09-23 05:42 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-09-20 01:38:38 PDT
If LBSE is activated and the document contains outermost <svg> elements, then dump the _whole_ document with sub pixel precision for both the renderer and the layer sizes & coordinates.
This gives a consistent picture of how these trees actually look like in memory -- way easier to judge these outputs then thinking about the different rounding/snapping modes when comparing e.g. layer / renderer positions, etc.
Comment 1 Nikolas Zimmermann 2022-09-20 01:41:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4521
Comment 2 EWS 2022-09-23 05:41:49 PDT
Committed 254784@main (dfd977a53df9): <https://commits.webkit.org/254784@main>

Reviewed commits have been landed. Closing PR #4521 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-23 05:42:22 PDT
<rdar://problem/100321115>