Bug 245415 - worker and other values are valid keyword for the 'as' property in link preload
Summary: worker and other values are valid keyword for the 'as' property in link preload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2022-09-20 01:03 PDT by Karl Dubost
Modified: 2024-05-23 10:28 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2022-09-20 01:03:32 PDT
When a document contains:

  <link rel="preload" href="main.js" as="worker" />

Safari reports:

  <link rel=preload> must have a valid `as` value


Probably a couple of tests are missing from 
https://wpt.fyi/results/html/syntax/speculative-parsing/generated/page-load?label=master&label=experimental&aligned&view=subtest&q=preload

or https://wpt.fyi/results/fetch/metadata/preload.https.sub.html?label=master&label=experimental&aligned&view=subtest&q=preload

or in 
https://wpt.fyi/results/preload/reflected-as-value.html?label=master&label=experimental&aligned&view=subtest&q=preload



The fetch spec definition:
https://fetch.spec.whatwg.org/#concept-request-destination

> A request has an associated destination, which is the empty string, "audio", "audioworklet", "document", "embed", "font", "frame", "iframe", "image", "manifest", "object", "paintworklet", "report", "script", "serviceworker", "sharedworker", "style", "track", "video", "worker", or "xslt". Unless stated otherwise it is the empty string.
> 
> A request’s destination is script-like if it is "audioworklet", "paintworklet", "script", "serviceworker", "sharedworker", or "worker".


It seems there are a couple of values which are not defined such as video for example.
Comment 1 Karl Dubost 2022-09-20 01:15:51 PDT
It seems to be defined in 
https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLLinkElement.cpp#236-253
Comment 2 Radar WebKit Bug Importer 2022-09-20 01:16:35 PDT
<rdar://problem/100161255>
Comment 4 Karl Dubost 2022-09-29 02:22:42 PDT
Related https://github.com/whatwg/html/issues/8332
Comment 5 youenn fablet 2022-10-14 00:44:26 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5367
Comment 6 EWS 2022-10-18 01:38:51 PDT
Committed 255669@main (e53707dae94c): <https://commits.webkit.org/255669@main>

Reviewed commits have been landed. Closing PR #5367 and removing active labels.