Bug 245372 - Factorize border code in RenderTreeAsText
Summary: Factorize border code in RenderTreeAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthieu Dubet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-19 12:50 PDT by Matthieu Dubet
Modified: 2022-09-19 15:57 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Dubet 2022-09-19 12:50:19 PDT 
There is some duplication in RenderTreeAsText::writeRenderObject, we should improve this.
Comment 1 Matthieu Dubet 2022-09-19 13:12:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4499
Comment 2 Radar WebKit Bug Importer 2022-09-19 13:36:24 PDT 
<rdar://problem/100136833>
Comment 3 EWS 2022-09-19 15:22:01 PDT 
Committed 254647@main (4bc684c9be49): <https://commits.webkit.org/254647@main>

Reviewed commits have been landed. Closing PR #4499 and removing active labels.
Comment 4 Simon Fraser (smfr) 2022-09-19 15:57:34 PDT 
> There is some duplication in RenderTreeAsText::writeRenderObject, we should improve this.

This info should have been in the commit message.