Bug 245363 - Cleanup RenderLayer::updateLayerPosition()
Summary: Cleanup RenderLayer::updateLayerPosition()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-19 06:41 PDT by Nikolas Zimmermann
Modified: 2022-11-19 17:17 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-09-19 06:41:13 PDT 
- Avoid unnecessary LayoutSize <-> LayoutPoint conversions
- Use dynamicDowncast() where possible
- Code de-duplication (re-use checks from RenderLayerCompositor)
- Remove inlineBoundingBoxOffset hack from updateLayerPosition(), no longer needed
- Refactor layer size & location computation to be less intrusive
Comment 1 Nikolas Zimmermann 2022-09-19 06:50:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4483
Comment 2 Nikolas Zimmermann 2022-09-19 14:45:47 PDT 
This is part of the work done for LBSE, but doesn't "block" bug 90738, removing that dependency again.
Comment 3 Radar WebKit Bug Importer 2022-09-26 06:42:17 PDT 
<rdar://problem/100408829>
Comment 4 EWS 2022-11-19 17:17:46 PST 
Committed 256880@main (6eebc817120b): <https://commits.webkit.org/256880@main>

Reviewed commits have been landed. Closing PR #4483 and removing active labels.