Bug 245362 - Use dynamicDowncast() in RenderBox::offsetFromContainer()
Summary: Use dynamicDowncast() in RenderBox::offsetFromContainer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-19 06:33 PDT by Nikolas Zimmermann
Modified: 2022-09-19 14:45 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-09-19 06:33:01 PDT 
When both if<Foo> + downcast<Foo> are used, dynamicDowncast() is preferred (less repetitive).
Comment 1 Nikolas Zimmermann 2022-09-19 06:34:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4482
Comment 2 EWS 2022-09-19 14:03:46 PDT 
Committed 254644@main (cfb088fd5663): <https://commits.webkit.org/254644@main>

Reviewed commits have been landed. Closing PR #4482 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-19 14:04:25 PDT 
<rdar://problem/100138658>
Comment 4 Nikolas Zimmermann 2022-09-19 14:45:33 PDT 
Well, this is part of the work done for LBSE, but doesn't "block" bug 90738, removing that dependency again.