Bug 245333 - REGRESSION(254574@main): Triggers ASSERTS when running wpt tests
Summary: REGRESSION(254574@main): Triggers ASSERTS when running wpt tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-18 04:28 PDT by Philippe Normand
Modified: 2022-09-18 08:19 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-09-18 04:28:13 PDT 
Doing an ASSERT_NOT_REACHED() for a feature not implemented seems a bit odd. Usually notImplemented() is used instead.

Test: imported/w3c/web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.html and more

STDERR: SHOULD NEVER BE REACHED
STDERR: /app/webkit/Source/WebKit/UIProcess/WebPageProxy.cpp(7093) : void WebKit::WebPageProxy::setTextIndicator(const WebCore::TextIndicatorData&, uint64_t)
Comment 1 Philippe Normand 2022-09-18 04:42:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4456
Comment 2 EWS 2022-09-18 08:19:08 PDT 
Committed 254610@main (b8caa5b21cd3): <https://commits.webkit.org/254610@main>

Reviewed commits have been landed. Closing PR #4456 and removing active labels.