245211 – Remove 'KHTMLNowrap' and 'CSSWebkitNowrap' since now it is not used after Tables Quirk

Bug 245211 - Remove 'KHTMLNowrap' and 'CSSWebkitNowrap' since now it is not used after Tables Quirk

Summary: Remove 'KHTMLNowrap' and 'CSSWebkitNowrap' since now it is not used after Tab...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	Safari Technology Preview
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Ahmad Saleem

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-09-15 00:27 PDT by Ahmad Saleem
Modified:	2022-09-16 07:32 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ahmad Saleem 2022-09-15 00:27:51 PDT

Hi Team,

No other browser support KHTML Nowarp and we also removed the last usage in Bug 183642.

I am thinking of removing it from:

https://github.com/WebKit/WebKit/blob/c888c485b787e204057b56d69536aae567ab8b3a/Source/WebCore/rendering/style/RenderStyleConstants.h#L708

https://github.com/WebKit/WebKit/blob/8fd683703b324056047dcbb939050b4b4f159eff/Source/WebCore/rendering/style/RenderStyleConstants.cpp#L1251

https://github.com/WebKit/WebKit/blob/11dc05a5914734bd841eb8a66e7034352d9a61b4/Source/WebCore/css/CSSPrimitiveValueMappings.h#L2826

https://github.com/WebKit/WebKit/blob/11dc05a5914734bd841eb8a66e7034352d9a61b4/Source/WebCore/css/CSSPrimitiveValueMappings.h#L2840

This just removal of dead code and it will not impact any test case or any web-exposed feature drastically since no other browser have it.

Just creating a bug to do later on.

Thank!

Comment 1 EWS 2022-09-16 07:31:59 PDT

Committed 254556@main (719db0d99a39): <https://commits.webkit.org/254556@main>

Reviewed commits have been landed. Closing PR #4373 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2022-09-16 07:32:18 PDT

<rdar://problem/100026288>