Bug 245177 - Refactor CSSTransition::create() to only take RenderStyle references
Summary: Refactor CSSTransition::create() to only take RenderStyle references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-14 05:58 PDT by Antoine Quint
Modified: 2022-09-15 02:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-09-14 05:58:26 PDT 
Currently CSSTransition::create() takes a RenderStyle* for the oldStyle parameter, but it makes no sense since a transition necessarily operates on an underlying style. This should be a RenderStyle&.
Comment 1 Antoine Quint 2022-09-14 06:02:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4344
Comment 2 EWS 2022-09-15 02:11:03 PDT 
Committed 254510@main (e65b4584d9c6): <https://commits.webkit.org/254510@main>

Reviewed commits have been landed. Closing PR #4344 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-15 02:12:18 PDT 
<rdar://problem/99959496>