Bug 245138 - Some color related CSS properties are not properly initialized
Summary: Some color related CSS properties are not properly initialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-13 06:47 PDT by Matthieu Dubet
Modified: 2022-09-13 14:40 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Dubet 2022-09-13 06:47:08 PDT 
At least textFillColor, textStrokeColor, textDecorationColor, textEmphasisColor.

They all should have a proper initialization function in RenderStyle which should initialize them to currentcolor (per spec).

Currently, they don't have their own initialization function and default-initialized to Color {}, which is invalid and thus is later "interpreted" as currentcolor. This is working "by accident".
Comment 1 Matthieu Dubet 2022-09-13 06:50:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4308
Comment 2 EWS 2022-09-13 14:39:41 PDT 
Committed 254458@main (466a830e85aa): <https://commits.webkit.org/254458@main>

Reviewed commits have been landed. Closing PR #4308 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-13 14:40:19 PDT 
<rdar://problem/99889356>