Bug 245108 - Add type for PlatformMouseEvent modifier flags
Summary: Add type for PlatformMouseEvent modifier flags
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 47651 171297
Blocks:
  Show dependency tree / graph
 
Reported: 2022-09-12 19:17 PDT by David Kilzer (:ddkilzer)
Modified: 2022-09-12 20:46 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-09-12 19:17:55 PDT 
Add type for PlatformMouseEvent modifier flags.

Only Mac and Windows actually use modifier flags on the PlatformMouseEvent object and AFAICT:
- The `unsigned` type is not big enough for either the `NSEventModifierFlags` type on macOS or the `WPARAM` type on Windows.
- The instance variable is never used on iOS/tvOS/watchOS platforms.
- The lack of type may have caused conversion to the wrong enum value in the fix for Bug 171297 (188192@main).

Need to check with some experts what MacCatalyst should do in these cases.
Comment 1 Radar WebKit Bug Importer 2022-09-12 19:18:34 PDT 
<rdar://problem/99850228>
Comment 2 David Kilzer (:ddkilzer) 2022-09-12 20:46:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4293