Bug 245088 - Modernize PlatformCAAnimationWin.cpp similar to PlatformCAAnimationCocoa.mm
Summary: Modernize PlatformCAAnimationWin.cpp similar to PlatformCAAnimationCocoa.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 244874 245052
Blocks:
  Show dependency tree / graph
 
Reported: 2022-09-12 11:22 PDT by David Kilzer (:ddkilzer)
Modified: 2022-09-16 10:27 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-09-12 11:22:44 PDT 
Modernize PlatformCAAnimationWin.cpp similar to PlatformCAAnimationCocoa.mm.

This patch contains my leftover changes after Alex landed this build fix:

    REGRESSION(254322@main) PlatformCAAnimationWin.cpp(550,86): error C2660: 'CFArrayAppendValue': function does not take 1 arguments
    https://bugs.webkit.org/show_bug.cgi?id=245052
    Canonical link: https://commits.webkit.org/254385@main
Comment 1 Radar WebKit Bug Importer 2022-09-12 11:23:20 PDT 
<rdar://problem/99830432>
Comment 2 David Kilzer (:ddkilzer) 2022-09-12 11:53:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4273
Comment 3 EWS 2022-09-13 05:26:34 PDT 
Committed 254430@main (ec3619c5a844): <https://commits.webkit.org/254430@main>

Reviewed commits have been landed. Closing PR #4273 and removing active labels.
Comment 4 David Kilzer (:ddkilzer) 2022-09-13 09:29:29 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/4315
Comment 5 EWS 2022-09-13 15:49:44 PDT 
Committed 254460@main (c020d23d66d1): <https://commits.webkit.org/254460@main>

Reviewed commits have been landed. Closing PR #4315 and removing active labels.