Bug 245070 - [GTK][WPE] Stop using injected bundle messages for implementing resource loader API
Summary: [GTK][WPE] Stop using injected bundle messages for implementing resource load...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2022-09-12 04:55 PDT by Carlos Garcia Campos
Modified: 2022-11-07 01:13 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-09-12 04:55:51 PDT 
At the beginning this was not exposed in WebKit2 APIS, so we had to use custom injected bundle messages to keeps exposing this.
Comment 1 Carlos Garcia Campos 2022-09-12 04:59:55 PDT 
I tried using API::ResourceLoadClient but it's not enough for what we have now. It missed the resources loaded from the disk cache (this sounds like bug because there's loadedFromCache in API::ResourceLoadInfo) and also the ones loaded from the memory cache, because this client receives messages from the network process, not the web process. So, can we just add a resource load client specific for GTK and WPE to stop using injected bundle messages?
Comment 2 Carlos Garcia Campos 2022-09-27 04:35:33 PDT 
Alex, would you be ok with adding internal api just for GTK/WPE to implement web resources loader from the web process but without using injected bundle?
Comment 3 Carlos Garcia Campos 2022-10-17 00:41:18 PDT 
Alex? Youenn? Chris?
Comment 4 Carlos Garcia Campos 2022-11-02 07:26:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/6036
Comment 5 EWS 2022-11-07 01:13:56 PST 
Committed 256388@main (051a04847864): <https://commits.webkit.org/256388@main>

Reviewed commits have been landed. Closing PR #6036 and removing active labels.