Bug 245064 - RTCDataChannelRemoteManager registers for work queue messages in wrong way
Summary: RTCDataChannelRemoteManager registers for work queue messages in wrong way
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-12 00:47 PDT by Kimmo Kinnunen
Modified: 2022-09-22 03:02 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-09-12 00:47:14 PDT 
RTCDataChannelRemoteManager registers for work queue messages in wrong way

RTCDataChannelRemoteManager:
 - is RefCounted but the initial ref is never adopted as expected
 - registers a work queue message handler before the vptr is correctly setup
   risking incorrect virtual function calls to the instance from another
   thread
Comment 1 Radar WebKit Bug Importer 2022-09-12 00:48:43 PDT 
<rdar://problem/99812041>
Comment 2 Kimmo Kinnunen 2022-09-12 00:52:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4250
Comment 3 EWS 2022-09-22 03:02:51 PDT 
Committed 254752@main (18c0882056e4): <https://commits.webkit.org/254752@main>

Reviewed commits have been landed. Closing PR #4250 and removing active labels.