Bug 245061 - [WGSL] Run WGSL unit tests on EWS
Summary: [WGSL] Run WGSL unit tests on EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on: 244792
Blocks:
  Show dependency tree / graph
 
Reported: 2022-09-11 22:20 PDT by Dan Glastonbury
Modified: 2022-09-23 18:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-09-11 22:20:54 PDT 
We have WGSLUnitTests, which is an XCTest-based unit tests for WGSL parsing, which aren't currently run on EWS. We should work out how to do that.
Comment 1 Radar WebKit Bug Importer 2022-09-11 22:21:29 PDT 
<rdar://problem/99808942>
Comment 2 Dan Glastonbury 2022-09-11 22:30:32 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4247
Comment 3 Dan Glastonbury 2022-09-13 18:41:49 PDT 
Ported Lexer and Parser tests to gtest to run in EWS.
Comment 4 EWS 2022-09-19 18:05:27 PDT 
Committed 254654@main (5bda1cab2367): <https://commits.webkit.org/254654@main>

Reviewed commits have been landed. Closing PR #4247 and removing active labels.
Comment 5 Ryan Haddad 2022-09-22 13:25:01 PDT 
Reverted in https://commits.webkit.org/254764@main due to this change breaking the watchOS and tvOS builds.
Comment 6 Dan Glastonbury 2022-09-22 19:35:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4615
Comment 7 EWS 2022-09-23 18:08:06 PDT 
Committed 254813@main (3561019e2cc1): <https://commits.webkit.org/254813@main>

Reviewed commits have been landed. Closing PR #4615 and removing active labels.