Bug 245042 - Avoid constructing InputType in HTMLInputElement::updateType whenever possible
Summary: Avoid constructing InputType in HTMLInputElement::updateType whenever possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-10 20:25 PDT by Ryosuke Niwa
Modified: 2022-09-12 08:52 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-09-10 20:25:30 PDT 
Right now, HTMLInputElement::updateType always creates InputType of the new type
just to check whether the type string has changed or not.

Avoid this construction as a perf optimization.
Comment 1 Ryosuke Niwa 2022-09-10 20:29:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4231
Comment 2 EWS 2022-09-12 08:51:01 PDT 
Committed 254383@main (62339dafa6fc): <https://commits.webkit.org/254383@main>

Reviewed commits have been landed. Closing PR #4231 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-12 08:52:20 PDT 
<rdar://problem/99823605>