RESOLVED FIXED245019
Use 'break' instead of 'continue' in a 'do { } while (false)' loop 
https://bugs.webkit.org/show_bug.cgi?id=245019
Summary Use 'break' instead of 'continue' in a 'do { } while (false)' loop
David Kilzer (:ddkilzer)
Reported 2022-09-09 21:09:17 PDT
Use 'break' instead of 'continue' in a 'do { } while (false)' loop. In Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp: ``` bool CDMSessionClearKey::update(Uint8Array* rawKeysData, RefPtr<Uint8Array>& nextMessage, unsigned short& errorCode, uint32_t& systemCode) { [...] do { auto rawKeysString = String::fromUTF8(rawKeysData->data(), rawKeysData->length()); if (rawKeysString.isEmpty()) { LOG(Media, "CDMSessionClearKey::update(%p) - failed: empty message", this); continue; } [...] } while (false); [...] } ``` Found by CodeQL.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-09-09 21:09:39 PDT
<rdar://problem/99770949>
David Kilzer (:ddkilzer)
Comment 2 2022-09-09 21:14:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4213
EWS
Comment 3 2022-09-12 11:04:10 PDT
Committed 254393@main (4c4c0a117195): <https://commits.webkit.org/254393@main> Reviewed commits have been landed. Closing PR #4213 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.