Bug 245018 - angle_version.h and angle_version_info.h should not use the same header guard macro
Summary: angle_version.h and angle_version_info.h should not use the same header guard...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-09 20:56 PDT by David Kilzer (:ddkilzer)
Modified: 2022-09-12 07:29 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-09-09 20:56:36 PDT 
angle_version.h and angle_version_info.h should not use the same header guard macro.

Currently they both use:

#ifndef COMMON_VERSION_H_
#define COMMON_VERSION_H_
[...]
#endif  // COMMON_VERSION_H_

Found by CodeQL.
Comment 1 Radar WebKit Bug Importer 2022-09-09 20:57:01 PDT 
<rdar://problem/99770768>
Comment 2 David Kilzer (:ddkilzer) 2022-09-09 21:00:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4212
Comment 3 EWS 2022-09-11 22:46:57 PDT 
Committed 254370@main (1a61b3dac3ce): <https://commits.webkit.org/254370@main>

Reviewed commits have been landed. Closing PR #4212 and removing active labels.