RESOLVED FIXED244988
Always emit JavaScript signposts 
https://bugs.webkit.org/show_bug.cgi?id=244988
Summary Always emit JavaScript signposts
Ben Nham
Reported 2022-09-09 10:31:28 PDT
In bug 244006 we conditionalized emitting os_signposts based on the DBG_APPS kdebug class. This is not necessary for JavaScript signposts since the JS signposts are already conditionalized behind the exposeProfilersOnGlobalObject option. Another issue here is that Instruments doesn't enable the DBG_APPS kdebug class by default, and some members of the JSC team prefer using Instruments. This means that the JS signposts end up not being emitted at all. Fix this by always emitting signposts from the JS API.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-09-09 10:32:29 PDT
<rdar://problem/99750295>
Ben Nham
Comment 2 2022-09-09 10:33:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4176
EWS
Comment 3 2022-09-13 10:22:13 PDT
Committed 254445@main (00a2349badb3): <https://commits.webkit.org/254445@main> Reviewed commits have been landed. Closing PR #4176 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.