Bug 244988 - Always emit JavaScript signposts
Summary: Always emit JavaScript signposts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-09 10:31 PDT by Ben Nham
Modified: 2022-09-13 10:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-09-09 10:31:28 PDT 
In bug 244006 we conditionalized emitting os_signposts based on the DBG_APPS kdebug class. This is not necessary for JavaScript signposts since the JS signposts are already conditionalized behind the exposeProfilersOnGlobalObject option. Another issue here is that Instruments doesn't enable the DBG_APPS kdebug class by default, and some members of the JSC team prefer using Instruments. This means that the JS signposts end up not being emitted at all. Fix this by always emitting signposts from the JS API.
Comment 1 Radar WebKit Bug Importer 2022-09-09 10:32:29 PDT 
<rdar://problem/99750295>
Comment 2 Ben Nham 2022-09-09 10:33:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4176
Comment 3 EWS 2022-09-13 10:22:13 PDT 
Committed 254445@main (00a2349badb3): <https://commits.webkit.org/254445@main>

Reviewed commits have been landed. Closing PR #4176 and removing active labels.