Bug 244919 - Make FontCache use ThreadSpecific instead of ThreadGlobalData
Summary: Make FontCache use ThreadSpecific instead of ThreadGlobalData
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
: 246627 (view as bug list)
Depends on: 247774
Blocks: 183720 246627
  Show dependency tree / graph
 
Reported: 2022-09-07 19:06 PDT by Matt Woodrow
Modified: 2024-04-09 03:40 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-09-07 19:06:26 PDT 
ThreadGlobalData doesn't handle the case where we try to access it while it's being shut down, and the font code tries to do that.

ThreadSpecific should be faster, and safe for this case.
Comment 1 Matt Woodrow 2022-09-07 19:14:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4118
Comment 2 Radar WebKit Bug Importer 2022-09-14 19:07:27 PDT 
<rdar://problem/99947922>
Comment 3 EWS 2022-10-26 21:32:12 PDT 
Committed 256048@main (21308fa925b8): <https://commits.webkit.org/256048@main>

Reviewed commits have been landed. Closing PR #4118 and removing active labels.
Comment 4 WebKit Commit Bot 2022-11-10 17:46:24 PST 
Re-opened since this is blocked by bug 247774
Comment 5 Kimmo Kinnunen 2024-04-09 03:40:11 PDT 
*** Bug 246627 has been marked as a duplicate of this bug. ***