Bug 244915 - TextureMapperGL::beginRoundedRectClip should use TransformationMatrix::mapQuad instead of TransformationMatrix::projectQuad
Summary: TextureMapperGL::beginRoundedRectClip should use TransformationMatrix::mapQua...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-07 17:33 PDT by Fujii Hironori
Modified: 2022-09-14 17:34 PDT (History)
5 users (show)

See Also:

Attachments
WIP patch (1.22 KB, patch)
2022-09-07 17:34 PDT, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
wrong test case (wrong explanation in the test) (912 bytes, text/html)
2022-09-07 17:36 PDT, Fujii Hironori 		no flags Details
test case (912 bytes, text/html)
2022-09-07 17:37 PDT, Fujii Hironori 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-09-07 17:33:32 PDT 
TextureMapperGL::beginRoundedRectClip should use TransformationMatrix::mapQuad instead of TransformationMatrix::projectQuad

TextureMapperGL::beginRoundedRectClip and TextureMapperGL::beginScissorClip are using projectQuad.
But, projectQuad is used mainly for hit testing by using a inversed matrix.
projectQuad produces the same results with mapQuad if the transformation matrix has not z-axis transformation.

I think there is no actual problem for beginRoundedRectClip and beginScissorClip to use projectQuad.
But, it should be mapQuad.
Comment 1 Fujii Hironori 2022-09-07 17:34:18 PDT 
Created attachment 462191 [details]
WIP patch
Comment 2 Fujii Hironori 2022-09-07 17:36:22 PDT 
Created attachment 462192 [details]
wrong test case (wrong explanation in the test)

Because mapQuad has a problem at the moment (bug#244824), this patch introduces a regression in case of w<0.
Comment 3 Fujii Hironori 2022-09-07 17:37:21 PDT 
Created attachment 462193 [details]
test case
Comment 4 Radar WebKit Bug Importer 2022-09-14 17:34:19 PDT 
<rdar://problem/99945034>