Bug 244882 - IPC::Attachment is used as an encoded type on Darwin and Windows
Summary: IPC::Attachment is used as an encoded type on Darwin and Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-07 00:47 PDT by Kimmo Kinnunen
Modified: 2022-09-12 06:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-09-07 00:47:00 PDT 
IPC::Attachment is used as an encoded object

The original intent is that IPC::Attachment is an attachment to the IPC message.
Attachments are needed for those objects that cannot be transferred as data.

Incorrect:
Encode Connection port:
  - Interpret the Connection port as an Attachment
  - Encode the Attachment
    - Attachment::encode attaches the attachment to the Encoder attachments list

Correct:
Encode Connection port:
  - Construct an Attachment from the Connection port
  - Attach the Attachment to the Encoder attachments list
Comment 1 Radar WebKit Bug Importer 2022-09-07 00:47:44 PDT 
<rdar://problem/99638429>
Comment 2 Kimmo Kinnunen 2022-09-07 01:03:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4090
Comment 3 EWS 2022-09-12 06:57:05 PDT 
Committed 254379@main (5540bc1e9de4): <https://commits.webkit.org/254379@main>

Reviewed commits have been landed. Closing PR #4090 and removing active labels.