Bug 244874 - Make TimingFunction serialization a little more sane
Summary: Make TimingFunction serialization a little more sane
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 245088
  Show dependency tree / graph
 
Reported: 2022-09-06 19:27 PDT by Alex Christensen
Modified: 2022-09-12 11:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-09-06 19:27:06 PDT 
Instead of having asymmetric encode/decode functions, make them symmetric and generated.  Also use enum classes more, and don't store m_type since we have a vtable pointer already.
Comment 1 Alex Christensen 2022-09-06 20:19:37 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4086
Comment 2 EWS 2022-09-09 13:21:09 PDT 
Committed 254322@main (4cc03269dc5d): <https://commits.webkit.org/254322@main>

Reviewed commits have been landed. Closing PR #4086 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-09 13:22:18 PDT 
<rdar://problem/99757064>
Comment 4 Fujii Hironori 2022-09-11 13:25:38 PDT 
Bug 245052 – REGRESSION(254322@main) PlatformCAAnimationWin.cpp(550,86): error C2660: 'CFArrayAppendValue': function does not take 1 arguments