Bug 244755 - Stop calling NSDisableScreenUpdates()/NSEnableScreenUpdates()
Summary: Stop calling NSDisableScreenUpdates()/NSEnableScreenUpdates()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-02 20:27 PDT by Simon Fraser (smfr)
Modified: 2022-09-07 10:02 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-09-02 20:27:58 PDT 
NSDisableScreenUpdates()/NSEnableScreenUpdates() are no-ops for applications linked on Catalina or later. We call these when showing/hiding the fullscreen window, which is UI that webkit controls, so it should be safe to remove them.
Comment 1 Simon Fraser (smfr) 2022-09-02 20:29:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3986
Comment 2 EWS 2022-09-07 10:01:28 PDT 
Committed 254239@main (0ddb0cb7d5bb): <https://commits.webkit.org/254239@main>

Reviewed commits have been landed. Closing PR #3986 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-07 10:02:19 PDT 
<rdar://problem/99654312>