Bug 244739 - [LFC][IFC] Introduce the concept of "placed" float boxes
Summary: [LFC][IFC] Introduce the concept of "placed" float boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-02 16:31 PDT by zalan
Modified: 2022-09-04 15:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.15 KB, patch)
2022-09-02 16:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.16 KB, patch)
2022-09-04 10:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.16 KB, patch)
2022-09-04 11:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-09-02 16:31:36 PDT 
ssia
Comment 1 zalan 2022-09-02 16:37:14 PDT 
Created attachment 462107 [details]
Patch
Comment 2 Antti Koivisto 2022-09-04 07:37:53 PDT 
Comment on attachment 462107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462107&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66
> +    using FloatList = Vector<const InlineItem*>;

I suppose the type could also be PlacedFloats because that is the only thing it is used for (for now?).
Comment 3 Antti Koivisto 2022-09-04 07:39:59 PDT 
or PlacedFloatItems or something
Comment 4 zalan 2022-09-04 09:08:19 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 462107 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462107&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66
> > +    using FloatList = Vector<const InlineItem*>;
> 
> I suppose the type could also be PlacedFloats because that is the only thing
> it is used for (for now?).
The upcoming patch with "overflowing floats" gonna use this type.
Comment 5 zalan 2022-09-04 10:25:17 PDT 
Created attachment 462122 [details]
Patch
Comment 6 zalan 2022-09-04 11:27:29 PDT 
Created attachment 462124 [details]
Patch
Comment 7 EWS 2022-09-04 15:56:58 PDT 
Committed 254151@main (7bdac4ad13a4): <https://commits.webkit.org/254151@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462124 [details].
Comment 8 Radar WebKit Bug Importer 2022-09-04 15:57:15 PDT 
<rdar://problem/99552170>