Bug 244711 - [LFC] Remove ENABLE_LAYOUT_FORMATTING_CONTEXT define
Summary: [LFC] Remove ENABLE_LAYOUT_FORMATTING_CONTEXT define
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-02 04:35 PDT by Antti Koivisto
Modified: 2022-09-02 08:46 PDT (History)
23 users (show)

See Also:

Attachments
Patch (192.70 KB, patch)
2022-09-02 04:55 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-09-02 04:35:00 PDT 
LFC is our standard system for inline layout. We don't ever want to compile it out.
Comment 1 Radar WebKit Bug Importer 2022-09-02 04:35:29 PDT 
<rdar://problem/99483972>
Comment 2 Antti Koivisto 2022-09-02 04:55:10 PDT 
Created attachment 462094 [details]
Patch
Comment 3 zalan 2022-09-02 05:50:19 PDT 
Comment on attachment 462094 [details]
Patch

v.nice.
Comment 4 Michael Catanzaro 2022-09-02 07:40:02 PDT 
Comment on attachment 462094 [details]
Patch

I had been wondering about why this was still gated behind the experimental feature guard ever since you mentioned it was intended to be default everywhere.

I don't like running different code on Apple vs. Linux unless there's a strong reason to be different, so this seems good to me.

BTW now is the perfect time to enable new features, since the new GTK/WPE stable branch was just created. We have half a year to test changes made now before they reach users.
Comment 5 Antti Koivisto 2022-09-02 07:52:27 PDT 
Great!
Comment 6 EWS 2022-09-02 08:46:31 PDT 
Committed 254102@main (3a4ed38babac): <https://commits.webkit.org/254102@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462094 [details].