Bug 244653 - [webkitdirs] Detect when internal builds are using the open-source workspace
Summary: [webkitdirs] Detect when internal builds are using the open-source workspace
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-31 19:05 PDT by Elliott Williams
Modified: 2023-01-21 04:04 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-08-31 19:05:12 PDT 
It's easy for an Apple engineer to accidentally try to build WebKit from the open-source workspace, rather than an internal workspace which contains extra bits needed to compile WebKit successfully on internal SDKs. The failure mode is pretty cryptic: builds usually fail with missing symbols during linking, etc.

Let's check for this condition before building, so build-webkit or Make can fail early with a useful message.
Comment 1 Radar WebKit Bug Importer 2022-08-31 19:05:48 PDT 
<rdar://problem/99415058>
Comment 2 Elliott Williams 2022-08-31 19:18:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3901
Comment 3 EWS 2022-09-01 12:06:00 PDT 
Committed 254059@main (d398a88b431e): <https://commits.webkit.org/254059@main>

Reviewed commits have been landed. Closing PR #3901 and removing active labels.
Comment 4 EWS 2022-09-01 13:21:38 PDT 
Committed 254064@main (1c3a52cd871e): <https://commits.webkit.org/254064@main>

Reviewed commits have been landed. Closing PR #3927 and removing active labels.
Comment 5 Elliott Williams 2022-09-01 16:21:22 PDT 
Reverted by https://github.com/WebKit/WebKit/pull/3938
Comment 6 EWS 2022-09-01 18:12:58 PDT 
Committed 254083@main (3f0eab0693e7): <https://commits.webkit.org/254083@main>

Reviewed commits have been landed. Closing PR #3938 and removing active labels.
Comment 7 Elliott Williams 2022-09-02 10:37:00 PDT 
Reverted because this change was breaking builds when a Makefile sets WORKSPACE_PATH.
Comment 8 Elliott Williams 2022-10-06 13:46:18 PDT 
Another thing we could do here, once this is functional, is to have webkitdirs.pm change its default workspace to the internal one when the SDK ends in ".internal".