Bug 244624 - [GLib] Deprecate WebKitSettings enable-frame-flattening
Summary: [GLib] Deprecate WebKitSettings enable-frame-flattening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-31 12:22 PDT by Michael Catanzaro
Modified: 2022-09-01 05:31 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-08-31 12:22:51 PDT 
Deprecate WebKitSettings enable-frame-flattening since the implementation was removed in bug #242883
Comment 1 Michael Catanzaro 2022-08-31 13:53:39 PDT 
We cannot remove the underlying preference from WebPreferences.yaml and WebPreferencesInternal.yaml because it still supports public API in WebKitLegacy/mac/WebView/WebPreferences.mm and WebKitLegacy/mac/WebView/WebView.mm.
Comment 2 Michael Catanzaro 2022-08-31 14:32:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3876
Comment 3 EWS 2022-08-31 16:02:26 PDT 
Committed 254014@main (1978c2756325): <https://commits.webkit.org/254014@main>

Reviewed commits have been landed. Closing PR #3876 and removing active labels.
Comment 4 Yanko Kaneti 2022-09-01 03:45:44 PDT 
I am not sure I understand the logic here.
It marks as deprecated which is OK, but also turns the setting in a noop default to false ?
Which would not help evolution which explicitly sets it to true to actually use the now deprecated code

Maybe my code comprehension is failing me..
Comment 5 Michael Catanzaro 2022-09-01 05:28:58 PDT 
That's the patch for the main branch. For the 2.38 branch, I instead committed exactly the patch that you uploaded on Red Hat Bugzilla:

https://github.com/WebKit/WebKit/commit/871eeae26321fc4d5f6769887f2aae42200b5a6e

And a different deprecation that keeps the setting alive:

https://github.com/WebKit/WebKit/commit/a94dc7e25c83a375fd9ac3e73f56c2794336b176
Comment 6 Yanko Kaneti 2022-09-01 05:31:11 PDT 
Ah, thanks, I missed the branch difference.
Sorry for the noise