Bug 244553 - Skip installing logging preference plist on downlevel builds
Summary: Skip installing logging preference plist on downlevel builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-30 13:27 PDT by Ben Nham
Modified: 2022-08-31 12:24 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-08-30 13:27:51 PDT 
The downlevel installer doesn't work right now because it is trying to install a logging preference plist to /System/Library/Preferences (see bug 243699). To fix this, we should avoid emitting this plist when building for a downlevel installer by checking for the presence of WK_ALTERNATE_FRAMEWORKS_DIR.
Comment 1 Ben Nham 2022-08-30 13:28:32 PDT 
rdar://99344600
Comment 2 Ben Nham 2022-08-30 13:30:16 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3823
Comment 3 EWS 2022-08-31 12:24:34 PDT 
Committed 254004@main (226a0d2f0798): <https://commits.webkit.org/254004@main>

Reviewed commits have been landed. Closing PR #3823 and removing active labels.