Bug 244534 - [GStreamer] MediaPlayerPrivateGStreamer: Abort stale tasks on flushes
Summary: [GStreamer] MediaPlayerPrivateGStreamer: Abort stale tasks on flushes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-30 06:38 PDT by Alicia Boya García
Modified: 2022-09-04 07:08 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2022-08-30 06:38:56 PDT 
This patch is a combination of a follow-up of
https://github.com/WebKit/WebKit/pull/3746, and a fix for a race
condition I independently discovered before said PR was published.

Minor cleanups for pr/3746 are done, additional logging is added,
MediaPlayerPrivateGStreamer::m_abortableTaskQueue is renamed to
MediaPlayerPrivateGStreamer::m_sinkTaskQueue, comments are added, and
most importantly: the task queue is flushed when a GStreamer flush is
received. This fixes a race condition on MSE flushes.
Comment 1 Alicia Boya García 2022-08-30 06:42:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3802
Comment 2 EWS 2022-09-04 07:08:36 PDT 
Committed 254142@main (e55d1903cf10): <https://commits.webkit.org/254142@main>

Reviewed commits have been landed. Closing PR #3802 and removing active labels.