WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
244534
[GStreamer] MediaPlayerPrivateGStreamer: Abort stale tasks on flushes
https://bugs.webkit.org/show_bug.cgi?id=244534
Summary
[GStreamer] MediaPlayerPrivateGStreamer: Abort stale tasks on flushes
Alicia Boya García
Reported
2022-08-30 06:38:56 PDT
This patch is a combination of a follow-up of
https://github.com/WebKit/WebKit/pull/3746
, and a fix for a race condition I independently discovered before said PR was published. Minor cleanups for pr/3746 are done, additional logging is added, MediaPlayerPrivateGStreamer::m_abortableTaskQueue is renamed to MediaPlayerPrivateGStreamer::m_sinkTaskQueue, comments are added, and most importantly: the task queue is flushed when a GStreamer flush is received. This fixes a race condition on MSE flushes.
Attachments
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2022-08-30 06:42:00 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3802
EWS
Comment 2
2022-09-04 07:08:36 PDT
Committed
254142@main
(e55d1903cf10): <
https://commits.webkit.org/254142@main
> Reviewed commits have been landed. Closing PR #3802 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug