Bug 244524 - make_names.pl findTagName trie search code could be improved
Summary: make_names.pl findTagName trie search code could be improved
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 244768
Blocks:
  Show dependency tree / graph
 
Reported: 2022-08-29 18:58 PDT by Cameron McCormack (:heycam)
Modified: 2022-09-05 18:59 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-08-29 18:58:46 PDT 
Two suggestions that came out of the bug 244020 review:

1. When reaching the leaf of the trie, the suffix to compare against could be a string literal rather than an array of characters.
2. We sometimes put braces around single statements.
Comment 1 Cameron McCormack (:heycam) 2022-08-29 20:26:47 PDT 
3. The generated code sometimes includes a sequence of single character if statement checks.  These should be combined into a single memcmp.
Comment 2 Radar WebKit Bug Importer 2022-09-05 18:59:15 PDT 
<rdar://problem/99580507>