Bug 244421 - AX: AXObjectCache::remove(Node&) can be called while performing a cache update causing m_deferred* vectors to be modified as we iterate over them
Summary: AX: AXObjectCache::remove(Node&) can be called while performing a cache updat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-26 18:19 PDT by Tyler Wilcock
Modified: 2022-08-27 15:50 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2022-08-26 18:29 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (9.58 KB, patch)
2022-08-26 19:22 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (10.56 KB, patch)
2022-08-27 09:28 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (10.53 KB, patch)
2022-08-27 09:33 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (10.52 KB, patch)
2022-08-27 09:35 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-08-26 18:19:26 PDT 
AXObjectCache::remove(Node&) can be called while performing a cache update causing m_deferred* vectors to be modified as we iterate over them
Comment 1 Radar WebKit Bug Importer 2022-08-26 18:19:36 PDT 
<rdar://problem/99211879>
Comment 2 Tyler Wilcock 2022-08-26 18:19:58 PDT 
rdar://98729717
Comment 3 Tyler Wilcock 2022-08-26 18:29:34 PDT 
Created attachment 461909 [details]
Patch
Comment 4 chris fleizach 2022-08-26 19:11:52 PDT 
Comment on attachment 461909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461909&action=review

> COMMIT_MESSAGE:10
> +When this happens, the Node is removed m_deferredAttributeChanges while

Node is removed from
Comment 5 Tyler Wilcock 2022-08-26 19:22:56 PDT 
Created attachment 461911 [details]
Patch
Comment 6 Tyler Wilcock 2022-08-27 09:28:48 PDT 
Created attachment 461921 [details]
Patch
Comment 7 Tyler Wilcock 2022-08-27 09:33:54 PDT 
Created attachment 461922 [details]
Patch
Comment 8 Tyler Wilcock 2022-08-27 09:35:10 PDT 
Created attachment 461923 [details]
Patch
Comment 9 EWS 2022-08-27 15:50:10 PDT 
Committed 253871@main (77ab8bd37796): <https://commits.webkit.org/253871@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461923 [details].